Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/autocomplete/autocomplete.h

Issue 179028: Revert "Fix a ton of compiler warnings." (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/logging.h" 11 #include "base/logging.h"
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 // 459 //
460 // NOTE: Providers MUST only call this method while processing asynchronous 460 // NOTE: Providers MUST only call this method while processing asynchronous
461 // queries. Do not call this for a synchronous query. 461 // queries. Do not call this for a synchronous query.
462 // 462 //
463 // NOTE: There's no parameter to tell the listener _which_ provider is 463 // NOTE: There's no parameter to tell the listener _which_ provider is
464 // calling it. Because the AutocompleteController (the typical listener) 464 // calling it. Because the AutocompleteController (the typical listener)
465 // doesn't cache the providers' individual matches locally, it has to get 465 // doesn't cache the providers' individual matches locally, it has to get
466 // them all again when this is called anyway, so such a parameter wouldn't 466 // them all again when this is called anyway, so such a parameter wouldn't
467 // actually be useful. 467 // actually be useful.
468 virtual void OnProviderUpdate(bool updated_matches) = 0; 468 virtual void OnProviderUpdate(bool updated_matches) = 0;
469 protected:
470 ~ACProviderListener() {}
471 }; 469 };
472 470
473 AutocompleteProvider(ACProviderListener* listener, 471 AutocompleteProvider(ACProviderListener* listener,
474 Profile* profile, 472 Profile* profile,
475 const char* name) 473 const char* name)
476 : profile_(profile), 474 : profile_(profile),
477 listener_(listener), 475 listener_(listener),
478 done_(true), 476 done_(true),
479 name_(name) { 477 name_(name) {
480 } 478 }
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 AutocompleteInput::Type input_type; 868 AutocompleteInput::Type input_type;
871 // Selected index (if selected) or -1 (AutocompletePopupModel::kNoMatch). 869 // Selected index (if selected) or -1 (AutocompletePopupModel::kNoMatch).
872 size_t selected_index; 870 size_t selected_index;
873 // Inline autocompleted length (if displayed). 871 // Inline autocompleted length (if displayed).
874 size_t inline_autocompleted_length; 872 size_t inline_autocompleted_length;
875 // Result set. 873 // Result set.
876 const AutocompleteResult& result; 874 const AutocompleteResult& result;
877 }; 875 };
878 876
879 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_ 877 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
OLDNEW
« no previous file with comments | « base/waitable_event_watcher_unittest.cc ('k') | chrome/browser/autocomplete/autocomplete_edit.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698