Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1790001: Add a V8 specific target architecture to the GYP file... (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add a V8 specific target architecture to the GYP file The V8 GYP file now uses its own target architecture. It default to the standard target_arch, but can be set to a separate value. E.g. using export GYP_DEFINES="target_arch=ia32 v8_target_arch=arm" makes it possible to have the V8 ARM simulator be used in a IA32 build. Added some checking of supported host/target architecture combinations. Committed: http://code.google.com/p/v8/source/detail?r=4490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M src/globals.h View 1 chunk +19 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 9 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-26 09:27:02 UTC) #1
Erik Corry
10 years, 8 months ago (2010-04-26 10:55:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698