Avoid constant pool blocking for too long...

Avoid constant pool blocking for too long

The generation of the deferred code for named property load where the load was inlined did a constant pool blocking for the whole deferred code. Having large numbers of this type of deferred code generated one ofter the other effectively blocked the constant pool for all the deferred code causing 

Removed the BeforeGenerate/AfterGenerate for the deferred code and made macro assembler StartBlockConstPool/EndBlockConstPool non-public. Re-introduced BlockConstPoolFor instead to use with BlockConstPoolScope to block some more instructions cross function calls.

Also handle the use of native code counters for inlined named property load.

Committed: http://code.google.com/p/v8/source/detail?r=4507

[Erik Corry, 2010-04-27 08:44:28]

LGTM

http://codereview.chromium.org/1787005/diff/1/5
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1787005/diff/1/5#newcode356
src/arm/codegen-arm.cc:356: // Check that the size of the code used for
returning matches what is
Indentation

http://codereview.chromium.org/1787005/diff/1/5#newcode5253
src/arm/codegen-arm.cc:5253: // inobject has been inlined.
inobject -> in-object case

http://codereview.chromium.org/1787005/diff/1/5#newcode5280
src/arm/codegen-arm.cc:5280: // having it in the instruction stream below where
patching will occour.
occour -> occur

[Søren Thygesen Gjesse, 2010-04-27 09:10:20]

http://codereview.chromium.org/1787005/diff/1/5
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1787005/diff/1/5#newcode356
src/arm/codegen-arm.cc:356: // Check that the size of the code used for
returning matches what is
On 2010/04/27 08:44:28, Erik Corry wrote:
> Indentation

Done.

http://codereview.chromium.org/1787005/diff/1/5#newcode5253
src/arm/codegen-arm.cc:5253: // inobject has been inlined.
On 2010/04/27 08:44:28, Erik Corry wrote:
> inobject -> in-object case

Done.

http://codereview.chromium.org/1787005/diff/1/5#newcode5280
src/arm/codegen-arm.cc:5280: // having it in the instruction stream below where
patching will occour.
On 2010/04/27 08:44:28, Erik Corry wrote:
> occour -> occur

Done.