Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1786001: remove omx_sink and buffer merge (Closed)

Created:
10 years, 8 months ago by jiesun
Modified:
7 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove OmxSink interface because Buffer Allocation will go through Allocator in the future, and all allocation required parameters will be passed to "Allocator factory" during intiailized phase of render/decoder. Remove OMX_BUFFERHEADERTYPE merge logic, this is based on assumptions that all vendor will use one frame per buffer scheme instead of one slice(multiple rows) per buffer which is specified by OpenMAX IL Spec. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45705

Patch Set 1 #

Patch Set 2 : unittest #

Patch Set 3 : more style #

Patch Set 4 : remove omx_sink #

Patch Set 5 : fix incremental build problem #

Patch Set 6 : one more missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -520 lines) Patch
M media/base/video_frame.h View 3 chunks +9 lines, -1 line 0 comments Download
M media/filters/omx_video_decode_engine.h View 1 2 3 chunks +2 lines, -44 lines 0 comments Download
M media/filters/omx_video_decode_engine.cc View 1 2 6 chunks +30 lines, -118 lines 0 comments Download
M media/omx/omx_codec.h View 1 2 3 4 7 chunks +8 lines, -20 lines 0 comments Download
M media/omx/omx_codec.cc View 1 2 3 4 8 chunks +13 lines, -68 lines 0 comments Download
M media/omx/omx_codec_unittest.cc View 1 2 3 4 11 chunks +21 lines, -73 lines 0 comments Download
M media/omx/omx_output_sink.h View 1 2 3 1 chunk +0 lines, -144 lines 0 comments Download
M media/tools/omx_test/file_sink.h View 1 2 3 4 3 chunks +2 lines, -12 lines 0 comments Download
M media/tools/omx_test/file_sink.cc View 2 chunks +1 line, -33 lines 0 comments Download
M media/tools/omx_test/omx_test.cc View 1 2 3 4 5 6 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jiesun
remove omx_sink logic remove merge omx buffer for one frame. some logic is temporary due ...
10 years, 8 months ago (2010-04-26 17:40:56 UTC) #1
Alpha Left Google
On 2010/04/26 17:40:56, jiesun wrote: > remove omx_sink logic > remove merge omx buffer for ...
10 years, 8 months ago (2010-04-26 22:46:23 UTC) #2
wjia(left Chromium)
10 years, 8 months ago (2010-04-27 00:15:42 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698