Issue 1784010: Adds a helper script to print out all package dependencies of a given package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1784010: Adds a helper script to print out all package dependencies of a given package. (Closed)

Created:
10 years, 7 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
tedbo

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

Adds a helper script to print out all package dependencies of a given package.

Patch Set 1 #

Patch Set 2 : Remove sh part of name #

Total comments: 2

Patch Set 3 : Add -v #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	A	src/scripts/get_package_list	View	2	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

petkov and I are looking at reducing the size of the image and removing unnecessary ...

10 years, 7 months ago (2010-04-29 17:11:42 UTC) #1

tedbo

10 years, 7 months ago (2010-05-07 17:43:40 UTC) #3

LGTM w/ minor comments

I think this is fine but what I tend to find more useful when trimming
dependencies is to use emerge with "-v" (to show USE flags that could be
potentially turned on/off) and also with "--tree".  The latter is probably not
well suited for your script.

http://codereview.chromium.org/1784010/diff/3001/4001
File src/scripts/get_package_list (right):

http://codereview.chromium.org/1784010/diff/3001/4001#newcode19
src/scripts/get_package_list:19: "The board for which the image was built." b
Trailing "b" character?

http://codereview.chromium.org/1784010/diff/3001/4001#newcode26
src/scripts/get_package_list:26: echo "Usage:  ./get_package_list.sh
chromeos-base/chromeos > package.list"
Drop the .sh from the name.

Expand Messages | Collapse Messages