Issue 1784006: Changes to image_to_live to copy stateful partition over

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1784006: Changes to image_to_live to copy stateful partition over (Closed)

Created:
10 years, 8 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone, seano

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

Changes to image_to_live to copy stateful partition over

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -1 line)			Patch
M	src/platform/init/chromeos_startup	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/scripts/image_to_live.sh	View	3 chunks	+27 lines, -1 line	1 comment	Download
M	src/scripts/remote_access.sh	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

seano

LGTM workflow-wise, some minor comments about creating & transferring the archive dirs.. http://codereview.chromium.org/1784006/diff/1/3 File src/scripts/image_to_live.sh ...

10 years, 8 months ago (2010-04-27 18:17:12 UTC) #2

seano

10 years, 8 months ago (2010-04-27 20:17:44 UTC) #3

LGTM for now. 

On 2010/04/27 18:17:12, seano wrote:
> LGTM workflow-wise, some minor comments about creating & transferring the
> archive dirs..
> 
> http://codereview.chromium.org/1784006/diff/1/3
> File src/scripts/image_to_live.sh (right):
> 
> http://codereview.chromium.org/1784006/diff/1/3#newcode65
> src/scripts/image_to_live.sh:65: # Copy over tar files.
> I might be missing the reason that you need to create tar files on disk and
scp
> them, but I think one tar command + a tarpipe via remote_sh is simpler and
> avoids making extraneous on-disk copies of stuff...
> 
> cd /tmp/s && sudo tar -c var/ dev_image | remote_sh "(cd /path/ && tar -x" ?

Expand Messages | Collapse Messages