Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing...

Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing NULL in place of a const BoundNetLog&.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45851

[cbentzel, 2010-04-28 14:21:15]

LGTM

Drive-by comments.

http://codereview.chromium.org/1783008/diff/12004/62006
File net/http/http_cache.cc (right):

http://codereview.chromium.org/1783008/diff/12004/62006#newcode166
net/http/http_cache.cc:166: int rv = transaction_->Start(&request_info_,
&callback_, BoundNetLog());
In this case, should you change HttpCache::WriteMetadata to take a BoundNetLog()
(and pass it in to the HttpCache::MetadataWriter)? 

It looks like the primary user of this is HttpCache::Transaction, which will
have a BoundNetLog. The unit tests which call this can just construct a default
one like all of the other changes you've made to unit tests.

http://codereview.chromium.org/1783008/diff/12004/62009
File net/proxy/proxy_service.h (right):

http://codereview.chromium.org/1783008/diff/12004/62009#newcode40
net/proxy/proxy_service.h:40: // with it to detect when the network setup has
changed. This is used to
Nit: Document lifetime/ownership expectations of net_log

[willchan no longer on Chromium, 2010-04-28 18:30:34]

LGTM

[eroman, 2010-04-28 18:37:22]

http://codereview.chromium.org/1783008/diff/12004/62006
File net/http/http_cache.cc (right):

http://codereview.chromium.org/1783008/diff/12004/62006#newcode166
net/http/http_cache.cc:166: int rv = transaction_->Start(&request_info_,
&callback_, BoundNetLog());
On 2010/04/28 14:21:15, cbentzel wrote:
> In this case, should you change HttpCache::WriteMetadata to take a
BoundNetLog()
> (and pass it in to the HttpCache::MetadataWriter)? 
> 
> It looks like the primary user of this is HttpCache::Transaction, which will
> have a BoundNetLog. The unit tests which call this can just construct a
default
> one like all of the other changes you've made to unit tests.
> 

Agreed.

HttpCache needs some more work so it logs information about all of its internal
transaction (like any if-modified-since it runs).

That is outside of the scope of this cleanup however, but thanks for pointing it
out.

http://codereview.chromium.org/1783008/diff/12004/62009
File net/proxy/proxy_service.h (right):

http://codereview.chromium.org/1783008/diff/12004/62009#newcode40
net/proxy/proxy_service.h:40: // with it to detect when the network setup has
changed. This is used to
On 2010/04/28 14:21:15, cbentzel wrote:
> Nit: Document lifetime/ownership expectations of net_log

Done.