Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 178055: Put a proper info.plist into the framework so we can codesign it.... (Closed)

Created:
11 years, 3 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Put a proper info.plist into the framework so we can codesign it. Update the tweak info.plist script to work on frameworks as well as apps. Remove the bundle version since the script manages that. BUG=20503 TEST=The framework should now have an valid info.plist file in it's resources folder. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25027

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M build/mac/tweak_app_infoplist View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/app/app-Info.plist View 1 chunk +0 lines, -2 lines 0 comments Download
A chrome/app/framework-Info.plist View 1 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/app/helper-Info.plist View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 4 chunks +28 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
TVL
11 years, 3 months ago (2009-09-01 12:41:58 UTC) #1
TVL
11 years, 3 months ago (2009-09-01 12:44:22 UTC) #2
Mark Mentovai
LG otherwise http://codereview.chromium.org/178055/diff/1/3 File chrome/app/framework-Info.plist (right): http://codereview.chromium.org/178055/diff/1/3#newcode18 Line 18: <string>0.1</string> It occurs to me that ...
11 years, 3 months ago (2009-09-01 13:14:58 UTC) #3
Mark Mentovai
11 years, 3 months ago (2009-09-01 13:22:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698