Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: chrome/browser/cocoa/status_bubble_mac.mm

Issue 178036: Status bubble obscures a link when download shelf is visible (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/status_bubble_mac.mm
===================================================================
--- chrome/browser/cocoa/status_bubble_mac.mm (revision 24577)
+++ chrome/browser/cocoa/status_bubble_mac.mm (working copy)
@@ -149,6 +149,13 @@
NSRect window_frame = [window_ frame];
window_frame.origin = [parent_ frame].origin;
+ // Adjust the position to sit on top of download shelf.
+ // |delegate_| can be nil during unit tests.
+ if (is_download_shelf_visible_) {
+ if ([delegate_ respondsToSelector:@selector(verticalOffsetForStatusBubble)])
+ window_frame.origin.y += [delegate_ verticalOffsetForStatusBubble];
+ }
+
// Get the cursor position relative to the popup.
cursor_location.x -= NSMaxX(window_frame);
cursor_location.y -= NSMaxY(window_frame);
@@ -187,12 +194,6 @@
[[window_ contentView] setStyle:STYLE_STANDARD];
}
- // |delegate_| can be nil during unit tests.
- if (is_download_shelf_visible_) {
- if ([delegate_ respondsToSelector:@selector(verticalOffsetForStatusBubble)])
- window_frame.origin.y += [delegate_ verticalOffsetForStatusBubble];
- }
-
[window_ setFrame:window_frame display:YES];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698