Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 178036: Status bubble obscures a link when download shelf is visible (Closed)

Created:
11 years, 3 months ago by vassili
Modified:
9 years, 7 months ago
Reviewers:
Paul Godavari
CC:
chromium-reviews_googlegroups.com, John Grabowski, Pam (message me for reviews), Ben Goodger (Google)
Visibility:
Public.

Description

Addresses the issue of the status bubble obscuring a link when the download shelf is visible. Fix: adjust the bubble position for the height of the shelf _before_ testing whether the mouse is too close to the bubble. BUG=19983 TEST=Follow the steps in the bug to test the bubble's move-out-of-the-way behavior with dowload shelf both visible and hidden.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/cocoa/status_bubble_mac.mm View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vassili
11 years, 3 months ago (2009-08-31 18:14:26 UTC) #1
Paul Godavari
LGTM.
11 years, 3 months ago (2009-08-31 19:14:50 UTC) #2
vassili
11 years, 3 months ago (2009-09-03 00:35:39 UTC) #3
I can't run a try job I guess because I'm not a committer, and I can't submit
this without running a try. Is this something you can do?

Powered by Google App Engine
This is Rietveld 408576698