Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 178034: RegExp: Remove unnecessary function from ARM specific code and convert condition to assertion. (Closed)

Created:
11 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

RegExp: Remove unnecessary function from ARM specific code and convert condition to assertion.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M src/arm/regexp-macro-assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Small review.
11 years, 3 months ago (2009-08-31 13:00:18 UTC) #1
Erik Corry
11 years, 3 months ago (2009-09-01 08:10:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698