Issue 17802: Inline the TimeDelta::From* construction functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17802: Inline the TimeDelta::From* construction functions. (Closed)

Created:
11 years, 11 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
brettw, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Inline the TimeDelta::From* construction functions. With GCC, we don't have much hope of inlining unless the defintion is in the header. This should also hopefully allow the compiler to do things like constant folding on the multiplications, etc.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -30 lines)			Patch
	M	base/time.h	View		1 chunk	+32 lines, -0 lines	0 comments	Download
	M	base/time.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

If this is what it takes... lgtm

Expand Messages | Collapse Messages