Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 178002: Send release events as well as press events in linux event mocking infrastruc... (Closed)

Created:
11 years, 3 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Send release events as well as press events in linux event mocking infrastructure. Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24650

Patch Set 1 #

Total comments: 2

Patch Set 2 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -35 lines) Patch
M chrome/browser/automation/ui_controls_linux.cc View 1 5 chunks +90 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
11 years, 3 months ago (2009-08-27 19:14:29 UTC) #1
sky
LGTM http://codereview.chromium.org/178002/diff/1/2 File chrome/browser/automation/ui_controls_linux.cc (right): http://codereview.chromium.org/178002/diff/1/2#newcode32 Line 32: : task_(task), type_(type), count_(count) { nit: the ...
11 years, 3 months ago (2009-08-27 19:24:18 UTC) #2
Evan Stade
11 years, 3 months ago (2009-08-27 19:50:52 UTC) #3
done and done

Powered by Google App Engine
This is Rietveld 408576698