Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1780015: Fix Dropping in the bookmark manager (Closed)

Created:
10 years, 7 months ago by feldstein
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org, mrossetti
Visibility:
Public.

Description

Fix Dropping in the bookmark manager Originally we were clearing the dragData member in a few places, including experimental.bookmarkManager.onDrop. This was triggered before the javascripts drop event so when it got to that point to drop a valid bookmark, it had already cleared itself out. Now it just posts a task with 0ms delay to let the real drop event handle the data before clearing it. Also clear the data on mouse up, which wasn't being handled in the case where you drag an element just a tiny bit, and no action is performed. BUG=none TEST=Ensure you can still drop stuff in the bmm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46006

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/bookmark_manager/main.html View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
feldstein
ptal
10 years, 7 months ago (2010-04-29 21:33:15 UTC) #1
arv (Not doing code reviews)
10 years, 7 months ago (2010-04-29 22:25:59 UTC) #2
LGTM with nits fixed

http://codereview.chromium.org/1780015/diff/1/2
File chrome/browser/resources/bookmark_manager/main.html (right):

http://codereview.chromium.org/1780015/diff/1/2#newcode899
chrome/browser/resources/bookmark_manager/main.html:899: var deferredClearData =
function() {
function f() {}

preferred over 

var f = function() {};

http://codereview.chromium.org/1780015/diff/1/2#newcode900
chrome/browser/resources/bookmark_manager/main.html:900:
setTimeout(boundClearData, 0);
setTimeout(boundClearData) also works in V8.

http://codereview.chromium.org/1780015/diff/1/2#newcode913
chrome/browser/resources/bookmark_manager/main.html:913:
chrome.experimental.bookmarkManager.onDragLeave.addListener(deferredClearData);
long line

Powered by Google App Engine
This is Rietveld 408576698