Skip dropping caches in each test and between iterations during factory tests.

Skip dropping caches in each test and between iterations during factory tests.

Dropping caches (writing back all dirty pages to disk and clearing all the caches) is not necessary for factory tests. It can reduce the latency significantly. The scale is about 27s -> 3s, for running 2 empty tests.

Since autotest is installed in the stateful partition. So change mod_image_for_test script to mount and modify the stateful partition in addition.

[Nick Sanders, 2010-04-29 04:10:12]

lgtm

[Nick Sanders, 2010-04-29 04:10:43]

lgtm w/ sat change

http://codereview.chromium.org/1780011/diff/2001/3001
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1780011/diff/2001/3001#newcode149
src/scripts/image_to_usb.sh:149: 
any reason to move this block?

http://codereview.chromium.org/1780011/diff/2001/3002
File src/scripts/mod_for_factory_scripts/400configAutotest (right):

http://codereview.chromium.org/1780011/diff/2001/3002#newcode14
src/scripts/mod_for_factory_scripts/400configAutotest:14:
drop_caches_between_iterations: False
we do want to drop caches before hardweare_SAT, or any memory test. Can you add
drop_caches=False to the control file where it calls hardware_SAT?

[Tom Wai-Hong Tam, 2010-04-29 04:47:51]

http://codereview.chromium.org/1780011/diff/2001/3001
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1780011/diff/2001/3001#newcode149
src/scripts/image_to_usb.sh:149: 
That makes autotest can be installed first to stateful partition and then
mod_image_for_test modifies it later.

http://codereview.chromium.org/1780011/diff/2001/3002
File src/scripts/mod_for_factory_scripts/400configAutotest (right):

http://codereview.chromium.org/1780011/diff/2001/3002#newcode14
src/scripts/mod_for_factory_scripts/400configAutotest:14:
drop_caches_between_iterations: False
Yes, we can. I will send another CL to do it.

[Nick Sanders, 2010-04-29 06:41:58]

lgtm

[kmixter1, 2010-04-29 15:14:09]

FYI

You should have mentioned that you were making mod_image_for_test now mount and
modify the stateful partition in your subject.  That seems like a significant
change outside of factory tests.

http://codereview.chromium.org/1780011/diff/2001/3002
File src/scripts/mod_for_factory_scripts/400configAutotest (right):

http://codereview.chromium.org/1780011/diff/2001/3002#newcode11
src/scripts/mod_for_factory_scripts/400configAutotest:11: cat >
${STATEFUL_DIR}/home/autotest-client/global_config.ini <<EOF
Seems like you can remove pushd and popd since you're using a full path here.

[Tom Wai-Hong Tam, 2010-04-30 02:19:23]

Thanks. Added it to the description.