Issue 1780009: Reland: Link the name of the extension on the management page to the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1780009: Reland: Link the name of the extension on the management page to the... (Closed)

Created:
10 years, 8 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, arv (Not doing code reviews), pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reland: Link the name of the extension on the management page to the gallery page, if the extension is from the gallery. BUG=29739 TEST=Install a gallery extension and a third-party extension and make sure the gallery extension name is a link (whereas the third party extension name is static text). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45807

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -14 lines)			Patch
M	chrome/browser/extensions/extension_context_menu_model.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/extensions_ui.html	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

Rafael, this is the same patch, except I forgot the three test data files in ...

10 years, 8 months ago (2010-04-28 00:00:46 UTC) #1

lgtm

Expand Messages | Collapse Messages