Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1775006: Adding speech synthesis library to access TTS feature in libcros. (Closed)

Created:
10 years, 8 months ago by Chaitanya
Modified:
9 years, 6 months ago
Reviewers:
oshima, DaveMoore
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Adding speech synthesis library to access TTS feature in libcros.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1 line) Patch
M chrome/browser/chromeos/cros/cros_library.h View 5 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_library.cc View 7 chunks +20 lines, -1 line 0 comments Download
A chrome/browser/chromeos/cros/mock_speech_synthesis_library.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/cros/speech_synthesis_library.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/cros/speech_synthesis_library.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Chaitanya
My older CL (now closed) was in a client pulled from a read-only repo. Hence ...
10 years, 8 months ago (2010-04-27 22:08:03 UTC) #1
Chaitanya
On 2010/04/27 22:08:03, Chaitanya wrote: > My older CL (now closed) was in a client ...
10 years, 8 months ago (2010-04-27 23:20:19 UTC) #2
Chaitanya
10 years, 8 months ago (2010-04-27 23:30:22 UTC) #3
Chaitanya
Sent a separate CL to update libcros: http://codereview.chromium.org/1726012/show
10 years, 8 months ago (2010-04-27 23:32:12 UTC) #4
DaveMoore
LGTM
10 years, 8 months ago (2010-04-28 17:53:16 UTC) #5
Chaitanya
10 years, 7 months ago (2010-04-28 22:21:01 UTC) #6
oshima
10 years, 7 months ago (2010-04-28 22:47:12 UTC) #7
lgtm

landed in r45872

On 2010/04/28 22:21:01, Chaitanya wrote:
>

Powered by Google App Engine
This is Rietveld 408576698