Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1774021: Modifies dev server to produce stateful gzip and modify image_to_live to use it. (Closed)

Created:
10 years, 7 months ago by sosa
Modified:
10 years, 7 months ago
Reviewers:
kmixter1, seano
CC:
chromium-os-reviews_chromium.org, Sam Leffler
Base URL:
ssh://git@chromiumos-git//chromeos
Visibility:
Public.

Description

Modifies dev server to produce stateful gzip and modify image_to_live to use it. TEST=Tested with image_to_live, memento_updater without image_to_live This mimics the update process of the real image for the stateful partition. By moving this the update into a separate script, I can add it to the gmerge package such that developers will not have to use image_to_live. This change also removes the dependency on tar.

Patch Set 1 #

Patch Set 2 : Readd pkgroot #

Patch Set 3 : Fix pkgroot #

Total comments: 4

Patch Set 4 : Fixes for seano #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -79 lines) Patch
M src/platform/dev/autoupdate.py View 1 2 3 4 chunks +71 lines, -39 lines 0 comments Download
A src/platform/dev/stateful_update.sh View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M src/scripts/build_image View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M src/scripts/image_to_live.sh View 1 2 4 chunks +10 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
Kmixter for script + image_to_live, seano for devserver changes
10 years, 7 months ago (2010-04-30 23:46:36 UTC) #1
sosa
+sleffler Will be adding stateful_update.sh to the gmerge package. This way to update from a ...
10 years, 7 months ago (2010-04-30 23:49:36 UTC) #2
seano
10 years, 7 months ago (2010-05-03 23:07:16 UTC) #3
Nice cleanup. lgtm++

http://codereview.chromium.org/1774021/diff/4001/5001
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/1774021/diff/4001/5001#newcode87
src/platform/dev/autoupdate.py:87: for i in range(0, 4):
Random nit: range(4) is fine..

http://codereview.chromium.org/1774021/diff/4001/5001#newcode125
src/platform/dev/autoupdate.py:125: web.debug('unzip image.zip failed.')
Did you test this out in -a mode? (e.g. serving buildbot-style image.zip dirs?)

http://codereview.chromium.org/1774021/diff/4001/5002
File src/platform/dev/stateful_update.sh (right):

http://codereview.chromium.org/1774021/diff/4001/5002#newcode23
src/platform/dev/stateful_update.sh:23: STATEFUL_UPDATE_URL="`dirname
\"$ROOT_UPDATE_URL\"`/stateful.image.gz"
use $(cmd) to get subshell output

http://codereview.chromium.org/1774021/diff/4001/5002#newcode39
src/platform/dev/stateful_update.sh:39: gzip -d "$STATEFUL_UPDATE"
You could wget to stdout and pipe it here, and forget about creating the
intermediate file. It doesn't look like you reuse it anywhere else, except to
clean it up again below.

Powered by Google App Engine
This is Rietveld 408576698