Fix the missing gtk options bug.

Fix the missing gtk options bug.

Native gtk options pages rely on host to call gtk_widget_show_all. Doing
this after options dialog's size allocated. This is because the
WrapLabelAtAllocationHack trick in ContentPageGtk needs container's size
allocated when the label is being shown.

BUG=<http://crosbug.com/2859>
TEST=Verify fix for ChromeOS issue 2859 and in sync status message in "Peronal Stuff" tab is wrapped correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45808

[sky, 2010-04-26 23:54:58]

http://codereview.chromium.org/1773006/diff/1/2
File chrome/browser/chromeos/options/options_window_view.cc (right):

http://codereview.chromium.org/1773006/diff/1/2#newcode201
chrome/browser/chromeos/options/options_window_view.cc:201: if (width()) {
Would it be better to put this in OnSizeAllocate, and only once?

[xiyuan, 2010-04-27 00:09:48]

http://codereview.chromium.org/1773006/diff/1/2
File chrome/browser/chromeos/options/options_window_view.cc (right):

http://codereview.chromium.org/1773006/diff/1/2#newcode201
chrome/browser/chromeos/options/options_window_view.cc:201: if (width()) {
On 2010/04/26 23:54:58, sky wrote:
> Would it be better to put this in OnSizeAllocate, and only once?
OptionsWindowView is derived from View/DialogDelegate rather than from
WidgetGtk. So could not do this in OnSizeAllocate. :)

Use intialized_ flag to just do this once.

[sky, 2010-04-27 16:57:13]

http://codereview.chromium.org/1773006/diff/5001/6001
File chrome/browser/chromeos/options/options_window_view.cc (right):

http://codereview.chromium.org/1773006/diff/5001/6001#newcode203
chrome/browser/chromeos/options/options_window_view.cc:203: initialized_ = true;
This means you're setting initialiazed_ at a different time. Is that ok?

[xiyuan, 2010-04-27 17:08:32]

Found that we could do the show all logic after Window show. It works and would
only do it once and no change to the initialized_ flag. :)

http://codereview.chromium.org/1773006/diff/5001/6001
File chrome/browser/chromeos/options/options_window_view.cc (right):

http://codereview.chromium.org/1773006/diff/5001/6001#newcode203
chrome/browser/chromeos/options/options_window_view.cc:203: initialized_ = true;
On 2010/04/27 16:57:13, sky wrote:
> This means you're setting initialiazed_ at a different time. Is that ok?

Found a better place to do this code and you don't need to worry about this. :)

[sky, 2010-04-27 17:21:42]

LGTM