Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 177049: On Linux, move the passing of filedescriptors to a dedicated socketpair(). (Closed)

Created:
11 years, 3 months ago by Markus (顧孟勤)
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

On Linux, move the passing of filedescriptors to a dedicated socketpair(). This allows the fast path to use read()/write() instead of recvmsg()/sendmsg() which is much cheaper for the Seccomp sandbox. Also, fixed minor seccomp sandbox issues discovered by this change. BUG=19120 ISSUE=164373

Patch Set 1 #

Patch Set 2 : Added Linux reference build #

Total comments: 4

Patch Set 3 : Removed *.d files from reference build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11874 lines, -8250 lines) Patch
M chrome/tools/test/reference_build/chrome_linux/chrome View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/chrome.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ar.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/bg.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/bn.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ca.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/cs.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/locales/da.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/de.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/el.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/en-GB.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/locales/en-US.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/es.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/es-419.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/et.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/fi.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/fil.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/fr.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/gu.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/locales/he.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/hi.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/hr.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/hu.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/id.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/it.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ja.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/kn.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ko.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/lt.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/lv.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ml.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/mr.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/nb.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/nl.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/or.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/pl.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/pt-BR.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/pt-PT.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ro.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ru.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/sk.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/sl.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/sr.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/sv.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/ta.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/te.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/th.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/tr.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/uk.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/vi.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/locales/zh-CN.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/locales/zh-TW.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/BottomUpProfileDataGridTree.js View 1 chunk +252 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Breakpoint.js View 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/BreakpointsSidebarPane.js View 5 chunks +88 lines, -6 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/CallStackSidebarPane.js View 4 chunks +62 lines, -6 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Callback.js View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/ChangesView.js View 1 chunk +80 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Color.js View 1 chunk +671 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Console.js View 1 chunk +0 lines, -942 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/ConsoleView.js View 1 chunk +912 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/CookieItemsView.js View 1 chunk +266 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/DOMAgent.js View 1 chunk +792 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/DOMStorage.js View 1 chunk +72 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/DOMStorageDataGrid.js View 1 chunk +165 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/DOMStorageItemsView.js View 1 chunk +112 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DataGrid.js View 9 chunks +160 lines, -4 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DatabaseQueryView.js View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DatabaseTableView.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DatabasesPanel.js View 1 chunk +0 lines, -526 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DebuggerConsole.js View 1 chunk +0 lines, -173 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DebuggerIPC.js View 1 chunk +0 lines, -109 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DebuggerPanel.js View 1 chunk +0 lines, -201 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/DebuggerShell.js View 1 chunk +0 lines, -1458 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Drawer.js View 1 chunk +202 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ElementsPanel.js View 20 chunks +162 lines, -323 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ElementsTreeOutline.js View 20 chunks +157 lines, -41 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/clearConsoleButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/clearConsoleButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/consoleButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/consoleButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/cookie.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/databasesIcon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/dockButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/dockButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/enableButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/enableOutlineButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/enableSolidButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/excludeButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/excludeButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/focusButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/focusButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/largerResourcesButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/largerResourcesButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/localStorage.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/nodeSearchButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/nodeSearchButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/pauseOnExceptionButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/pauseOnExceptionButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/percentButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/percentButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/radioDot.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/recordButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/recordButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/recordToggledButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/reloadButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/reloadButtons.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourcesSilhouette.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/sessionStorage.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/storageIcon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/undockButtonGlyph.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/userInputResultIcon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/InjectedScript.js View 1 chunk +988 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/KeyboardShortcut.js View 1 chunk +108 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/MetricsSidebarPane.js View 3 chunks +29 lines, -9 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ObjectPropertiesSection.js View 5 chunks +91 lines, -120 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/ObjectProxy.js View 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/PanelEnablerView.js View 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ProfileView.js View 12 chunks +34 lines, -80 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ProfilesPanel.js View 8 chunks +53 lines, -21 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/PropertiesSidebarPane.js View 2 chunks +17 lines, -7 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Resource.js View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ResourcesPanel.js View 17 chunks +140 lines, -327 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ScopeChainSidebarPane.js View 4 chunks +18 lines, -28 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/Script.js View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/ScriptsPanel.js View 14 chunks +113 lines, -34 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/SourceFrame.js View 7 chunks +72 lines, -2 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/SourceView.js View 1 chunk +13 lines, -5 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/StatusBarButton.js View 1 chunk +118 lines, -0 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/StoragePanel.js View 1 chunk +687 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/StylesSidebarPane.js View 30 chunks +487 lines, -113 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/SummaryBar.js View 1 chunk +364 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/TextPrompt.js View 4 chunks +12 lines, -5 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/TopDownProfileDataGridTree.js View 1 chunk +111 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/base.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/codemap.js View 7 chunks +34 lines, -6 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/debugger.css View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/debugger.html View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/debugger_agent.js View 30 chunks +556 lines, -287 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/devtools.css View 1 chunk +99 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/devtools.html View 5 chunks +33 lines, -20 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/devtools.js View 12 chunks +181 lines, -683 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/devtools_host_stub.js View 8 chunks +176 lines, -133 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/dom_agent.js View 1 chunk +0 lines, -1023 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/heap_profiler_panel.js View 1 chunk +680 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/inject.js View 1 chunk +104 lines, -423 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/inspector.css View 34 chunks +288 lines, -159 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/inspector.html View 4 chunks +18 lines, -7 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/inspector.js View 25 chunks +191 lines, -42 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/inspector_controller.js View 11 chunks +52 lines, -12 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/inspector_controller_impl.js View 10 chunks +188 lines, -23 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/json.js View 1 chunk +0 lines, -328 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/logreader.js View 1 chunk +320 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/net_agent.js View 1 chunk +0 lines, -126 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/profile.js View 1 chunk +17 lines, -1 line 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/profile_view.js View 4 chunks +34 lines, -61 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/profiler_processor.js View 3 chunks +340 lines, -93 lines 0 comments Download
A chrome/tools/test/reference_build/chrome_linux/resources/inspector/tests.js View 1 chunk +587 lines, -0 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/treeoutline.js View 3 chunks +16 lines, -13 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/resources/inspector/utilities.js View 15 chunks +47 lines, -234 lines 0 comments Download
M chrome/tools/test/reference_build/chrome_linux/themes/default.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
M ipc/ipc_channel_posix.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 17 chunks +215 lines, -38 lines 0 comments Download
M sandbox/linux/seccomp/syscall.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
agl
11 years, 3 months ago (2009-09-01 20:27:06 UTC) #1
Need to remove the .d files. LGTM.

http://codereview.chromium.org/177049/diff/2001/91
File ipc/ipc_channel_posix.cc (right):

http://codereview.chromium.org/177049/diff/2001/91#newcode359
Line 359: // As we cannot anticipate, when the sender will provide us with file
remove the comma

http://codereview.chromium.org/177049/diff/2001/91#newcode573
Line 573: DCHECK(payload_len % sizeof(int) == 0);
DCHECK_EQ

http://codereview.chromium.org/177049/diff/2001/91#newcode695
Line 695: if (output_queue_.empty()) {
Don't change the style of existing code unless it's outside the style guide.

http://codereview.chromium.org/177049/diff/2001/91#newcode699
Line 699: if (pipe_ == -1) {
same here.

Powered by Google App Engine
This is Rietveld 408576698