Linux: handle external protocols, e.g. mailto: links.

Linux: handle external protocols, e.g. mailto: links.
BUG=20696
TEST=click a mailto: link, it should open your default MUA


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25100

[Evan Stade, 2009-08-31 20:22:22]

http://codereview.chromium.org/177040/diff/1/2
File chrome/browser/external_protocol_handler.cc (right):

http://codereview.chromium.org/177040/diff/1/2#newcode169
Line 169: void ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(const
GURL& url) {
These ifdefs should be removed and the code moved to platform specific
implementations of OpenExternal().

[Mike Mammarella, 2009-08-31 21:21:10]

http://codereview.chromium.org/177040/diff/1/2
File chrome/browser/external_protocol_handler.cc (right):

http://codereview.chromium.org/177040/diff/1/2#newcode169
Line 169: void ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(const
GURL& url) {
On 2009/08/31 20:22:22, Evan Stade wrote:
> These ifdefs should be removed and the code moved to platform specific
> implementations of OpenExternal().

Done.

[Evan Stade, 2009-08-31 22:00:52]

lgtm

http://codereview.chromium.org/177040/diff/3004/1006
File chrome/browser/external_protocol_handler.cc (right):

http://codereview.chromium.org/177040/diff/3004/1006#newcode138
Line 138: // TODO(port): implement dialog for Mac
can you file a bug for the missing dialog (mac + linux) and update this todo

[Avi (use Gerrit), 2009-08-31 22:04:45]

http://codereview.chromium.org/177040/diff/3004/1008
File chrome/common/platform_util_mac.mm (right):

http://codereview.chromium.org/177040/diff/3004/1008#newcode39
Line 39: scoped_cftyperef<CFURLRef>
url_ref(CFURLCreateWithString(kCFAllocatorDefault,
If we're moving the code here, you should use NSWorkspace openURL: instead for
consistency.

[Mike Mammarella, 2009-09-01 03:09:30]

http://codereview.chromium.org/177040/diff/3004/1006
File chrome/browser/external_protocol_handler.cc (right):

http://codereview.chromium.org/177040/diff/3004/1006#newcode138
Line 138: // TODO(port): implement dialog for Mac
On 2009/08/31 22:00:52, Evan Stade wrote:
> can you file a bug for the missing dialog (mac + linux) and update this todo

Done.

http://codereview.chromium.org/177040/diff/3004/1008
File chrome/common/platform_util_mac.mm (right):

http://codereview.chromium.org/177040/diff/3004/1008#newcode39
Line 39: scoped_cftyperef<CFURLRef>
url_ref(CFURLCreateWithString(kCFAllocatorDefault,
On 2009/08/31 22:04:46, Avi wrote:
> If we're moving the code here, you should use NSWorkspace openURL: instead for
> consistency.

Done.

[Avi (use Gerrit), 2009-09-02 13:44:20]

LG

[szimszon, 2009-12-10 21:12:37]

Hello,

I wonder if somebody could help me.

My xdg-open supports file, ftp, http and https URLs, but not mailto:

xdg-email - command line tool for sending mail using the user’s
       preferred e-mail composer

[Mike Mammarella, 2009-12-10 22:02:31]

On 2009/12/10 21:12:37, szimszon wrote:
> Hello,
> 
> I wonder if somebody could help me.
> 
> My xdg-open supports file, ftp, http and https URLs, but not mailto:
> 
> xdg-email - command line tool for sending mail using the user’s
>        preferred e-mail composer

Hi szimszon, you should probably open a bug at http://crbug.com and include
information like what distribution you're running, what version of it you have,
what desktop environment you're using, and anything else that may be relevant to
why your xdg-open doesn't support this.