Issue 177026: Make the views bookmark bubble work on GTK....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177026: Make the views bookmark bubble work on GTK.... (Closed)

Created:
11 years, 3 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the views bookmark bubble work on GTK. The combobox still isn't implemented, but this makes TextBox work, and also does some changes around the info_bubble to make sure it get created properly. TEST=none BUG=none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24821

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -44 lines)
M	chrome/browser/views/bookmark_bubble_view.h	View	1 chunk	+2 lines, -0 lines	0 comments
M	chrome/browser/views/bookmark_bubble_view.cc	View	9 chunks	+16 lines, -4 lines	0 comments
M	chrome/browser/views/dialog_stubs_gtk.cc	View	1 chunk	+0 lines, -18 lines	0 comments
M	chrome/browser/views/info_bubble.h	View	2 chunks	+9 lines, -1 line	0 comments
M	chrome/browser/views/info_bubble.cc	View	4 chunks	+31 lines, -13 lines	0 comments
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments
M	views/controls/label.cc	View	1 chunk	+3 lines, -2 lines	0 comments
M	views/controls/native_control_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments
M	views/controls/textfield/native_textfield_gtk.h	View	1 chunk	+2 lines, -0 lines	0 comments
M	views/controls/textfield/native_textfield_gtk.cc	View	4 chunks	+68 lines, -4 lines	2 comments
M	views/widget/widget_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 3 months ago (2009-08-28 20:23:51 UTC) #2

LGTM

http://codereview.chromium.org/177026/diff/1013/15
File views/controls/textfield/native_textfield_gtk.cc (right):

http://codereview.chromium.org/177026/diff/1013/15#newcode18
Line 18: DCHECK(!(textfield_->style() & Textfield::STYLE_MULTILINE)) <<
Can you add a todo or make this a NOTIMPLEMENTED so that we don't miss it.

http://codereview.chromium.org/177026/diff/1013/15#newcode90
Line 90: gtk_editable_set_editable(GTK_EDITABLE(native_view()),
textfield_->IsEnabled());
nit: > 80

Expand Messages | Collapse Messages