Linux: about:memory

chrome/browser/browser_about_handler.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_about_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "app/l10n_util.h"
@@ skipping 602 matching lines @@
     titles->Append(new StringValue(info->titles[i]));
 }
 
 
 void AboutMemoryHandler::OnDetailsAvailable() {
   // the root of the JSON hierarchy for about:memory jstemplate
   DictionaryValue root;
   ListValue* browsers = new ListValue();
   root.Set(L"browsers", browsers);
 
-  ProcessData* browser_processes = processes();
+  const std::vector<ProcessData>& browser_processes = processes();
 
   // Aggregate per-process data into browser summary data.
   std::wstring log_string;
-  for (int index = 0; index < MemoryDetails::MAX_BROWSERS; index++) {
+  for (size_t index = 0; index < browser_processes.size(); index++) {
     if (browser_processes[index].processes.size() == 0)
       continue;
 
     // Sum the information for the processes within this browser.
     ProcessMemoryInformation aggregate;
-    ProcessMemoryInformationList::iterator iterator;
+    ProcessMemoryInformationList::const_iterator iterator;
     iterator = browser_processes[index].processes.begin();
     aggregate.pid = iterator->pid;
     aggregate.version = iterator->version;
     while (iterator != browser_processes[index].processes.end()) {
       if (!iterator->is_diagnostics ||
           browser_processes[index].processes.size() == 1) {
         aggregate.working_set.priv += iterator->working_set.priv;
         aggregate.working_set.shared += iterator->working_set.shared;
         aggregate.working_set.shareable += iterator->working_set.shareable;
         aggregate.committed.priv += iterator->committed.priv;
@@ skipping 128 matching lines @@
     AboutIPCDialog::RunDialog();
     return true;
   }
 #endif
 
 #else
   // TODO(port) Implement this.
 #endif
   return false;
 }