Issue 177018: Don't use the same descriptor array in several maps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177018: Don't use the same descriptor array in several maps (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Don't use the same descriptor array in several maps. Make a copy of the descriptor array when copying a map with pre-allocated properties. The garbage collector assumes that no two maps point to the same descriptor array. A simple reduction is missing. BUG=http://crbug.com/20330 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=2780

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 3 months ago (2009-08-28 11:07:18 UTC) #2

LGTM.

http://codereview.chromium.org/177018/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/177018/diff/1/2#newcode2932
Line 2932: Object* descriptors =
This entire test should be removed from CopyDropDescriptors, and instead done at
the call site where CopyDropDescriptors is used without immediately overwriting
the empty descriptor array.  But this is OK for now.

Expand Messages | Collapse Messages