Issue 1769014: Port string keyed load IC improvements (r4444) to ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1769014: Port string keyed load IC improvements (r4444) to ARM. (Closed)

Created:
10 years, 8 months ago by podivilov

Modified:
9 years, 3 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port string keyed load IC improvements (r4444) to ARM. Committed: http://code.google.com/p/v8/source/detail?r=4573

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 10 years, 7 months ago

	Unified diffs	Side-by-side diffs	Stats (+371 lines, -231 lines)
M	src/arm/codegen-arm.h	View	4 chunks	+71 lines, -36 lines	0 comments
M	src/arm/codegen-arm.cc	View	18 chunks	+221 lines, -144 lines	0 comments
M	src/arm/ic-arm.cc	View	1 chunk	+54 lines, -15 lines	0 comments
M	src/builtins.h	View	1 chunk	+1 line, -2 lines	0 comments
M	src/runtime.js	View	1 chunk	+0 lines, -11 lines	0 comments
M	src/x64/codegen-x64.h	View	2 chunks	+24 lines, -23 lines	0 comments

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 7 months ago (2010-04-30 12:23:36 UTC) #1

LGTM

http://codereview.chromium.org/1769014/diff/12001/13001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1769014/diff/12001/13001#newcode3959
src/arm/codegen-arm.cc:3959: void
CodeGenerator::GenerateFastCharCodeAt(ZoneList<Expression*>* args) {
Comments for this method in and inside it need to be updated.

http://codereview.chromium.org/1769014/diff/12001/13003
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/1769014/diff/12001/13003#newcode854
src/arm/ic-arm.cc:854: __ mov(ip, Operand(Factory::heap_number_map()));
LoadRoot?

Expand Messages | Collapse Messages