Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: net/base/x509_certificate.h

Issue 1769010: [Mac] Add locking as speculative fix for X509Certificate crashes. (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/x509_certificate_mac.cc » ('j') | net/base/x509_certificate_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate.h
diff --git a/net/base/x509_certificate.h b/net/base/x509_certificate.h
index 32c16f16bcc521c28e6b7b3b6f9ffade2eee13e5..f53035ada531df9e475b968e88e03bd6a06ca5cb 100644
--- a/net/base/x509_certificate.h
+++ b/net/base/x509_certificate.h
@@ -293,6 +293,11 @@ class X509Certificate : public base::RefCountedThreadSafe<X509Certificate> {
OSCertHandles intermediate_ca_certs_;
#endif
+#if defined(OS_MACOSX)
+ // Blocks multiple threads from verifying the cert simultaneously.
+ mutable Lock lock_;
wtc 2010/04/27 00:06:43 Nit: perhaps rename this lock "verify_lock_" to st
+#endif
+
// Where the certificate comes from.
Source source_;
« no previous file with comments | « no previous file | net/base/x509_certificate_mac.cc » ('j') | net/base/x509_certificate_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698