Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Side by Side Diff: src/arm/ic-arm.cc

Issue 1769005: Fix bug in KeyedLoadIC generic stub where signed instead of unsigned... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-685.js » ('j') | test/mjsunit/regress/regress-685.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 // Get the elements array of the object. 703 // Get the elements array of the object.
704 __ ldr(r1, FieldMemOperand(r1, JSObject::kElementsOffset)); 704 __ ldr(r1, FieldMemOperand(r1, JSObject::kElementsOffset));
705 // Check that the object is in fast mode (not dictionary). 705 // Check that the object is in fast mode (not dictionary).
706 __ ldr(r3, FieldMemOperand(r1, HeapObject::kMapOffset)); 706 __ ldr(r3, FieldMemOperand(r1, HeapObject::kMapOffset));
707 __ LoadRoot(ip, Heap::kFixedArrayMapRootIndex); 707 __ LoadRoot(ip, Heap::kFixedArrayMapRootIndex);
708 __ cmp(r3, ip); 708 __ cmp(r3, ip);
709 __ b(ne, &check_pixel_array); 709 __ b(ne, &check_pixel_array);
710 // Check that the key (index) is within bounds. 710 // Check that the key (index) is within bounds.
711 __ ldr(r3, FieldMemOperand(r1, Array::kLengthOffset)); 711 __ ldr(r3, FieldMemOperand(r1, Array::kLengthOffset));
712 __ cmp(r0, Operand(r3)); 712 __ cmp(r0, Operand(r3));
713 __ b(ge, &slow); 713 __ b(hs, &slow);
714 // Fast case: Do the load. 714 // Fast case: Do the load.
715 __ add(r3, r1, Operand(FixedArray::kHeaderSize - kHeapObjectTag)); 715 __ add(r3, r1, Operand(FixedArray::kHeaderSize - kHeapObjectTag));
716 __ ldr(r0, MemOperand(r3, r0, LSL, kPointerSizeLog2)); 716 __ ldr(r0, MemOperand(r3, r0, LSL, kPointerSizeLog2));
717 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 717 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
718 __ cmp(r0, ip); 718 __ cmp(r0, ip);
719 // In case the loaded value is the_hole we have to consult GetProperty 719 // In case the loaded value is the_hole we have to consult GetProperty
720 // to ensure the prototype chain is searched. 720 // to ensure the prototype chain is searched.
721 __ b(eq, &slow); 721 __ b(eq, &slow);
722 __ Ret(); 722 __ Ret();
723 723
(...skipping 1014 matching lines...) Expand 10 before | Expand all | Expand 10 after
1738 __ bind(&miss); 1738 __ bind(&miss);
1739 1739
1740 GenerateMiss(masm); 1740 GenerateMiss(masm);
1741 } 1741 }
1742 1742
1743 1743
1744 #undef __ 1744 #undef __
1745 1745
1746 1746
1747 } } // namespace v8::internal 1747 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-685.js » ('j') | test/mjsunit/regress/regress-685.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698