Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: WebCore/ChangeLog

Issue 1769002: BlobBuilder/FormData refactor attempt (Closed)
Patch Set: back to simple FormData Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WebCore/CMakeLists.txt ('k') | WebCore/GNUmakefile.am » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/ChangeLog
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index ec40737724d7058628d22afc6c99bf06cf29db9c..4e8ce02bc7358fab8f4abd47b19574f6a0d6f7c3 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,85 @@
+2010-06-03 Kinuko Yasuda <kinuko@chromium.org>
+
+ Reviewed by NOBODY (OOPS!).
+
+ Refactor FormData and Blob for better support of Blobs synthesized by BlobBuilder.
+ https://bugs.webkit.org/show_bug.cgi?id=39083
+
+ - Introduces a new class BlobItem as a basic component of Blob and
+ FormData and makes Blob as a collection of BlobItems.
+ - File would become a special type of Blob that contains only one
+ FileBlobItem.
+ - Makes FormDataElement a wrapper of BlobItem (as a transient
+ solution).
+ - Fix the dependency violation in FormData so that the files under
+ platform/ do not include any html/ files.
+
+ The patch doesn't support the latest File API changes (e.g. type,
+ url and slice's type parameters) and should not change any of its
+ existing behaviors.
+
+ The existing tests should be able to be used for regression.
+
+ * CMakeLists.txt:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * html/Blob.cpp:
+ (WebCore::Blob::Blob):
+ (WebCore::Blob::size):
+ (WebCore::Blob::path):
+ (WebCore::Blob::append):
+ (WebCore::Blob::slice):
+ * html/Blob.h:
+ (WebCore::Blob::create):
+ (WebCore::Blob::type):
+ (WebCore::Blob::items):
+ (WebCore::Blob::Blob):
+ * html/File.cpp:
+ (WebCore::File::File):
+ (WebCore::File::name):
+ * html/File.h:
+ (WebCore::File::fileName):
+ * html/FileReader.cpp:
+ (WebCore::FileReader::readAsBinaryString):
+ (WebCore::FileReader::readAsText):
+ * html/FileStream.cpp:
+ (WebCore::FileStream::openForRead):
+ * html/FormDataList.cpp:
+ (WebCore::FormDataList::appendString):
+ (WebCore::FormDataList::appendBlob):
+ * html/FormDataList.h:
+ (WebCore::FormDataList::items):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::createFormData):
+ * html/HTMLProgressElement.cpp:
+ * platform/BlobItem.cpp: Added.
+ * platform/BlobItem.h: Added.
+ * platform/network/FormData.cpp:
+ (WebCore::FormDataElement::FormDataElement):
+ (WebCore::FormData::create):
+ (WebCore::FormData::createMultiPart):
+ (WebCore::FormData::deepCopy):
+ (WebCore::FormData::appendData):
+ (WebCore::FormData::appendString):
+ (WebCore::FormData::appendFile):
+ (WebCore::FormData::appendFileRange):
+ (WebCore::FormData::appendItems):
+ (WebCore::FormData::appendItem):
+ (WebCore::FormData::appendKeyValuePairItems):
+ * platform/network/FormData.h:
+ (WebCore::operator!=):
+ * platform/network/mac/FormDataStreamMac.mm:
+ (WebCore::closeCurrentStream):
+ (WebCore::advanceCurrentStream):
+ (WebCore::formCreate):
+ (WebCore::formRead):
+ (WebCore::setHTTPBody):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::send):
+
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out aggressive cache part of the r60391
« no previous file with comments | « WebCore/CMakeLists.txt ('k') | WebCore/GNUmakefile.am » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698