Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: WebCore/ChangeLog

Issue 1769002: BlobBuilder/FormData refactor attempt (Closed)
Patch Set: back to simple FormData Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « WebCore/CMakeLists.txt ('k') | WebCore/GNUmakefile.am » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 2010-06-03 Kinuko Yasuda <kinuko@chromium.org>
2
3 Reviewed by NOBODY (OOPS!).
4
5 Refactor FormData and Blob for better support of Blobs synthesized by Bl obBuilder.
6 https://bugs.webkit.org/show_bug.cgi?id=39083
7
8 - Introduces a new class BlobItem as a basic component of Blob and
9 FormData and makes Blob as a collection of BlobItems.
10 - File would become a special type of Blob that contains only one
11 FileBlobItem.
12 - Makes FormDataElement a wrapper of BlobItem (as a transient
13 solution).
14 - Fix the dependency violation in FormData so that the files under
15 platform/ do not include any html/ files.
16
17 The patch doesn't support the latest File API changes (e.g. type,
18 url and slice's type parameters) and should not change any of its
19 existing behaviors.
20
21 The existing tests should be able to be used for regression.
22
23 * CMakeLists.txt:
24 * GNUmakefile.am:
25 * WebCore.gypi:
26 * WebCore.pro:
27 * WebCore.vcproj/WebCore.vcproj:
28 * WebCore.xcodeproj/project.pbxproj:
29 * html/Blob.cpp:
30 (WebCore::Blob::Blob):
31 (WebCore::Blob::size):
32 (WebCore::Blob::path):
33 (WebCore::Blob::append):
34 (WebCore::Blob::slice):
35 * html/Blob.h:
36 (WebCore::Blob::create):
37 (WebCore::Blob::type):
38 (WebCore::Blob::items):
39 (WebCore::Blob::Blob):
40 * html/File.cpp:
41 (WebCore::File::File):
42 (WebCore::File::name):
43 * html/File.h:
44 (WebCore::File::fileName):
45 * html/FileReader.cpp:
46 (WebCore::FileReader::readAsBinaryString):
47 (WebCore::FileReader::readAsText):
48 * html/FileStream.cpp:
49 (WebCore::FileStream::openForRead):
50 * html/FormDataList.cpp:
51 (WebCore::FormDataList::appendString):
52 (WebCore::FormDataList::appendBlob):
53 * html/FormDataList.h:
54 (WebCore::FormDataList::items):
55 * html/HTMLFormElement.cpp:
56 (WebCore::HTMLFormElement::createFormData):
57 * html/HTMLProgressElement.cpp:
58 * platform/BlobItem.cpp: Added.
59 * platform/BlobItem.h: Added.
60 * platform/network/FormData.cpp:
61 (WebCore::FormDataElement::FormDataElement):
62 (WebCore::FormData::create):
63 (WebCore::FormData::createMultiPart):
64 (WebCore::FormData::deepCopy):
65 (WebCore::FormData::appendData):
66 (WebCore::FormData::appendString):
67 (WebCore::FormData::appendFile):
68 (WebCore::FormData::appendFileRange):
69 (WebCore::FormData::appendItems):
70 (WebCore::FormData::appendItem):
71 (WebCore::FormData::appendKeyValuePairItems):
72 * platform/network/FormData.h:
73 (WebCore::operator!=):
74 * platform/network/mac/FormDataStreamMac.mm:
75 (WebCore::closeCurrentStream):
76 (WebCore::advanceCurrentStream):
77 (WebCore::formCreate):
78 (WebCore::formRead):
79 (WebCore::setHTTPBody):
80 * xml/XMLHttpRequest.cpp:
81 (WebCore::XMLHttpRequest::send):
82
1 2010-06-03 Pavel Feldman <pfeldman@chromium.org> 83 2010-06-03 Pavel Feldman <pfeldman@chromium.org>
2 84
3 Not reviewed. Rolling out aggressive cache part of the r60391 85 Not reviewed. Rolling out aggressive cache part of the r60391
4 described in the bug below. It was orthogonal to the rest of 86 described in the bug below. It was orthogonal to the rest of
5 the patch and caused regression. 87 the patch and caused regression.
6 88
7 https://bugs.webkit.org/show_bug.cgi?id=37364 89 https://bugs.webkit.org/show_bug.cgi?id=37364
8 90
9 * platform/graphics/skia/ImageSkia.cpp: 91 * platform/graphics/skia/ImageSkia.cpp:
10 (WebCore::drawResampledBitmap): 92 (WebCore::drawResampledBitmap):
(...skipping 6215 matching lines...) Expand 10 before | Expand all | Expand 10 after
6226 (WebCore::HTML5Token::appendToSystemIdentifier): 6308 (WebCore::HTML5Token::appendToSystemIdentifier):
6227 (WebCore::HTML5Token::DoctypeData::DoctypeData): 6309 (WebCore::HTML5Token::DoctypeData::DoctypeData):
6228 * html/HTML5TreeBuilder.cpp: 6310 * html/HTML5TreeBuilder.cpp:
6229 (WebCore::convertToOldStyle): 6311 (WebCore::convertToOldStyle):
6230 (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): 6312 (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
6231 * platform/text/SegmentedString.h: 6313 * platform/text/SegmentedString.h:
6232 (WebCore::SegmentedString::lookAheadIgnoringCase): 6314 (WebCore::SegmentedString::lookAheadIgnoringCase):
6233 (WebCore::SegmentedString::advanceAndASSERTIgnoringCase): 6315 (WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
6234 6316
6235 == Rolled over to ChangeLog-2010-05-24 == 6317 == Rolled over to ChangeLog-2010-05-24 ==
OLDNEW
« no previous file with comments | « WebCore/CMakeLists.txt ('k') | WebCore/GNUmakefile.am » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698