Issue 1765012: Add a single-element global positive and negative cache to...

Issue 1765012: Add a single-element global positive and negative cache to... (Closed)

Created:
10 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add a single-element global positive and negative cache to the implementation of instanceof. Committed: http://code.google.com/p/v8/source/detail?r=4599

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+449 lines, -3 lines)			Patch
M	src/arm/codegen-arm.cc	View	1	3 chunks	+21 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	src/arm/macro-assembler-arm.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
	src/heap.h	View	1	3 chunks	+15 lines, -0 lines	0 comments	Download
	src/heap.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
	src/ia32/codegen-ia32.cc	View	2	3 chunks	+29 lines, -1 line	0 comments	Download
	src/objects.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
	src/x64/codegen-x64.cc	View	2	5 chunks	+29 lines, -2 lines	0 comments	Download
	src/x64/macro-assembler-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	src/x64/macro-assembler-x64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	test/mjsunit/instanceof-2.js	View		1 chunk	+329 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Mads Ager (chromium)

LGTM Are you doing this on the other platforms as well? We should measure how ...

10 years, 7 months ago (2010-04-29 14:37:02 UTC) #2

Mads Ager (chromium)

I think you want to store stuff in the cache on x64 and ia32 as ...

10 years, 7 months ago (2010-05-03 13:18:52 UTC) #4

Erik Corry

On 2010/05/03 13:18:52, Mads Ager wrote: > I think you want to store stuff in ...

10 years, 7 months ago (2010-05-06 08:43:55 UTC) #5

Now with test!