Issue 1765008: Changes mac to call into AutocompleteEditModel method for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1765008: Changes mac to call into AutocompleteEditModel method for (Closed)

Created:
10 years, 8 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews

Visibility:
Public.

Description

Changes mac to call into AutocompleteEditModel method for determining text to copy to clipboard. BUG=41493 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45747

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -23 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		1 chunk	+15 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

LGTM, in that I think it replicates the prior experience. But it looks to me ...

10 years, 8 months ago (2010-04-27 19:57:31 UTC) #2

sky

10 years, 8 months ago (2010-04-27 20:23:18 UTC) #3

Yes, I think that's a separate bug that should be easy to fix now that
we have the single method everyone calls into.

  -Scott

On Tue, Apr 27, 2010 at 12:57 PM,  <shess@chromium.org> wrote:
> LGTM, in that I think it replicates the prior experience.
>
> But it looks to me like the old code and the new code maybe mis-handle the
> case
> where you've editing a non-http URL or don't have select-all.  For instance,
> if
> you have "https://blah.com/blah/#HASHCRAPHERE" and select everything before
> the
> #, you just get the text, even though it would make sense to get the URL,
> too.
>
> http://codereview.chromium.org/1765008/show
>

Expand Messages | Collapse Messages