Issue 1765006: cros: Use Vista-style window decorations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1765006: cros: Use Vista-style window decorations. (Closed)

Created:
10 years, 8 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

cros: Use Vista-style window decorations. We were previously using the Linux version's images but drawing them in the position needed by the Views images. BUG=40474 TEST=built the chrome os version Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45842

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	app/app.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	app/resources/app_resources.grd	View		2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 8 months ago (2010-04-27 02:50:42 UTC) #2

LGTM

http://codereview.chromium.org/1765006/diff/1/3
File app/resources/app_resources.grd (right):

http://codereview.chromium.org/1765006/diff/1/3#newcode34
app/resources/app_resources.grd:34: <if expr="not pp_ifdef('toolkit_views') and
(os == 'linux2' or os == 'freebsd7' or os == 'openbsd4')">
We really should use toolkit_gtk, but we don't even have that available in gyp.

Expand Messages | Collapse Messages