Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: src/apinatives.js

Issue 17639: Introducing a kUninitialized constant used for clearing the function cache. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/macros.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/apinatives.js
===================================================================
--- src/apinatives.js (revision 1056)
+++ src/apinatives.js (working copy)
@@ -65,7 +65,7 @@
var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
var isFunctionCached =
(serialNumber in cache) &&
- (cache[serialNumber] != -1);
+ (cache[serialNumber] != kUninitialized);
Mads Ager (chromium) 2009/01/13 07:35:37 This would fit on the line above now that the loca
olehougaard 2009/01/13 07:37:23 Fixed
if (!isFunctionCached) {
try {
cache[serialNumber] = null;
@@ -82,7 +82,7 @@
}
ConfigureTemplateInstance(fun, data);
} catch (e) {
- cache[serialNumber] = -1;
+ cache[serialNumber] = kUninitialized;
throw e;
}
}
« no previous file with comments | « no previous file | src/macros.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698