Introducing a kUninitialized constant used for clearing the function cache.

src/apinatives.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 47 matching lines @@
 }
 
 
 function InstantiateFunction(data, name) {
   // We need a reference to kApiFunctionCache in the stack frame
   // if we need to bail out from a stack overflow.
   var cache = kApiFunctionCache;
   var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
   var isFunctionCached =
    (serialNumber in cache) &&
-   (cache[serialNumber] != -1);
+   (cache[serialNumber] != kUninitialized);

[Mads Ager (chromium), 2009/01/13 07:35:37]

This would fit on the line above now that the local 'cache' variable is used.

[olehougaard, 2009/01/13 07:37:23]

Fixed

   if (!isFunctionCached) {
     try {
       cache[serialNumber] = null;
       var fun = %CreateApiFunction(data);
       if (name) %FunctionSetName(fun, name);
       cache[serialNumber] = fun;
       var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
       fun.prototype = prototype ? Instantiate(prototype) : {};
       %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
       var parent = %GetTemplateField(data, kApiParentTemplateOffset);
       if (parent) {
         var parent_fun = Instantiate(parent);
         fun.prototype.__proto__ = parent_fun.prototype;
       }
       ConfigureTemplateInstance(fun, data);
     } catch (e) {
-      cache[serialNumber] = -1;
+      cache[serialNumber] = kUninitialized;
       throw e;
     }
   }
   return cache[serialNumber];
 }
 
 
 function ConfigureTemplateInstance(obj, data) {
   var properties = %GetTemplateField(data, kApiPropertyListOffset);
   if (properties) {
     // Disable access checks while instantiating the object.
     var requires_access_checks = %DisableAccessChecks(obj);
     try {
       for (var i = 0; i < properties[0]; i += 3) {
         var name = properties[i + 1];
         var prop_data = properties[i + 2];
         var attributes = properties[i + 3];
         var value = Instantiate(prop_data, name);
         %SetProperty(obj, name, value, attributes);
       }
     } finally {
       if (requires_access_checks) %EnableAccessChecks(obj);
     }
   }
 }