Issue 17639: Introducing a kUninitialized constant used for clearing the function cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17639: Introducing a kUninitialized constant used for clearing the function cache. (Closed)

Created:
11 years, 11 months ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Introducing a kUninitialized constant used for clearing the function cache. Committed: http://code.google.com/p/v8/source/detail?r=1057

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/apinatives.js	View		2 chunks	+2 lines, -2 lines	2 comments	Download
	M	src/macros.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

http://codereview.chromium.org/17639/diff/1/3 File src/apinatives.js (right): http://codereview.chromium.org/17639/diff/1/3#newcode68 Line 68: (cache[serialNumber] != kUninitialized); This would fit on the ...

11 years, 11 months ago (2009-01-13 07:35:37 UTC) #3

olehougaard

11 years, 11 months ago (2009-01-13 07:37:23 UTC) #4

http://codereview.chromium.org/17639/diff/1/3
File src/apinatives.js (right):

http://codereview.chromium.org/17639/diff/1/3#newcode68
Line 68: (cache[serialNumber] != kUninitialized);
On 2009/01/13 07:35:37, Mads Ager wrote:
> This would fit on the line above now that the local 'cache' variable is used.

Fixed

Expand Messages | Collapse Messages