Issue 1763025: Die out autotest script if there is no board parameter specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1763025: Die out autotest script if there is no board parameter specified. (Closed)

Created:
10 years, 7 months ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Die out autotest script if there is no board parameter specified. BUG=3017

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/scripts/autotest	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 7 months ago (2010-04-30 22:26:21 UTC) #2

LGTM

Feel free to add  BUG= in the description.  I think that will cause
your change to show up in the bug then.

On Fri, Apr 30, 2010 at 2:14 PM,  <ericli@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Die out autotest script if there is no board parameter specified.
>
> Please review this at http://codereview.chromium.org/1763025/show
>
> SVN Base: ssh://git@chromiumos-git/chromeos
>
> Affected files:
>  M src/scripts/autotest
>
>
> Index: src/scripts/autotest
> diff --git a/src/scripts/autotest b/src/scripts/autotest
> index
>
ad4f0800f911291e79c7a1134d76388a2e49fc8b..8f7b699b9d6ff4c575737d8e1cfeb92959f66dc7
> 100755
> --- a/src/scripts/autotest
> +++ b/src/scripts/autotest
> @@ -213,6 +213,10 @@ def main():
>   set_common_env(common_sh, 'GCLIENT_ROOT')
>
>   options, args = parse_args_and_help()
> +
> +  if not options.board:
> +    die(common_sh, 'Missing --board argument.')
> +
>   if options.build:
>     status = build_autotest(options)
>     if status:
>
>
>

Expand Messages | Collapse Messages