Issue 1763013: Revert 45640 - Send out notifications when logins are changed through Passwor...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1763013: Revert 45640 - Send out notifications when logins are changed through Passwor... (Closed)

Created:
10 years, 8 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
albertb

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 45640 - Send out notifications when logins are changed through PasswordStoreMac so that the sync backend can register as an observer. BUG=35038 TEST=none Review URL: http://codereview.chromium.org/1752007 TBR=albertb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45661

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -113 lines)			Patch
M	chrome/browser/password_manager/password_store_mac.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.cc	View	6 chunks	+34 lines, -96 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

akalin (wrong akalin)

10 years, 8 months ago (2010-04-27 02:00:17 UTC) #2

FYI, reverted this because it was causing mac ui_test failures, eg.
http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests%20(dbg)...

On Mon, Apr 26, 2010 at 6:58 PM,  <akalin@chromium.org> wrote:
> Reviewers: albertb,
>
> Description:
> Revert 45640 - Send out notifications when logins are changed through
> PasswordStoreMac
> so that the sync backend can register as an observer.
>
> BUG=35038
> TEST=none
>
> Review URL: http://codereview.chromium.org/1752007
>
> TBR=albertb@chromium.org
>
> Please review this at http://codereview.chromium.org/1763013/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/password_manager/password_store_mac.h
>  M     chrome/browser/password_manager/password_store_mac.cc
>  M     chrome/common/notification_type.h
>
>
>



-- 
Frederick Akalin
Software Engineer

Expand Messages | Collapse Messages