Issue 1763012: more WiFi testing fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1763012: more WiFi testing fixes (Closed)

Created:
10 years, 8 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
seano, neb

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, ericli, petkov+cc_chromium.org, seano

Visibility:
Public.

Description

more WiFi testing fixes - fix client_check_* CL that was fubar - openwrt fixups: + use "bridgedv" and "wiredev" a la bsd code and sample configs + set htcaps for ht20 and ht so 802.11n is enabled + split out config knobs that need support + purge dead client_check_config code + config['hw_mode'] may not be set, deal with it (not sure if this is the right fix but it allows tests like CheckPerf24HT20 to run) Tested with WiFiMatFunc and WiFiSecMat suites; verified tests that previously failed now pass.

Patch Set 1 #

Total comments: 1

Patch Set 2 : use rstrip to chop \n's #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -27 lines)			Patch
	M	server/site_linux_router.py	View		6 chunks	+19 lines, -14 lines	0 comments	Download
	M	server/site_wifitest.py	View	1	3 chunks	+14 lines, -13 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

If this looks ok to you feel free to push it youself.

10 years, 8 months ago (2010-04-27 00:21:18 UTC) #1

seano

http://codereview.chromium.org/1763012/diff/1/3 File server/site_wifitest.py (right): http://codereview.chromium.org/1763012/diff/1/3#newcode339 server/site_wifitest.py:339: got = result.stdout[0:-1] # NB: chop \n result.stdout.rstrip()

10 years, 8 months ago (2010-04-27 19:33:57 UTC) #2

seano

10 years, 8 months ago (2010-04-28 19:05:53 UTC) #4

lgtm

http://codereview.chromium.org/1763012/diff/5001/6002
File server/site_wifitest.py (right):

http://codereview.chromium.org/1763012/diff/5001/6002#newcode339
server/site_wifitest.py:339: got = result.stdout.rstrip()       # NB: chop \n
unnecessary comment..

Expand Messages | Collapse Messages