Fix a chrome frame crasher reported on the crash server. It occurs while proc...

chrome_frame/chrome_active_document.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of ChromeActiveDocument
 #include "chrome_frame/chrome_active_document.h"
 
 #include <hlink.h>
 #include <htiface.h>
 #include <initguid.h>
@@ skipping 379 matching lines @@
 
   LARGE_INTEGER offset = {0};
   ULARGE_INTEGER new_pos = {0};
   DWORD written = 0;
   std::wstring url = UTF8ToWide(navigation_info_.url.spec());
   return stream->Write(url.c_str(), (url.length() + 1) * sizeof(wchar_t),
                        &written);
 }
 
 STDMETHODIMP ChromeActiveDocument::SetPositionCookie(DWORD position_cookie) {
-  int index = static_cast<int>(position_cookie);
-  navigation_info_.navigation_index = index;
-  automation_client_->NavigateToIndex(index);
+  if (automation_client_.get()) {
+    int index = static_cast<int>(position_cookie);
+    navigation_info_.navigation_index = index;
+    automation_client_->NavigateToIndex(index);
+  } else {
+    DLOG(WARNING) << "Invalid automation client instance";
+  }
   return S_OK;
 }
 
 STDMETHODIMP ChromeActiveDocument::GetPositionCookie(DWORD* position_cookie) {
   if (!position_cookie)
     return E_INVALIDARG;
 
   *position_cookie = navigation_info_.navigation_index;
   return S_OK;
 }
@@ skipping 390 matching lines @@
     // Grab a reference to ensure that the document remains valid.
     AddRef();
     g_active_doc_cache.Set(this);
   }
 
   BaseActiveX::OnOpenURL(tab_handle, url_to_open, referrer, open_disposition);
 }
 
 void ChromeActiveDocument::OnAttachExternalTab(int tab_handle,
     const IPC::AttachExternalTabParams& params) {
+  if (!automation_client_.get()) {
+    DLOG(WARNING) << "Invalid automation client instance";
+    return;
+  }
   DWORD flags = 0;
   if (params.user_gesture)
     flags = NWMF_USERREQUESTED;
   else if (popup_allowed_)
     flags = NWMF_USERALLOWED;
 
   HRESULT hr = S_OK;
   if (popup_manager_) {
     LPCWSTR popup_wnd_url = UTF8ToWide(params.url.spec()).c_str();
     hr = popup_manager_->EvaluateNewWindow(popup_wnd_url, NULL, url_,
@@ skipping 151 matching lines @@
     if (!allow_gcf_protocol)
       return false;
   }
 
   *parsed_url = initial_url;
   return true;
 }
 
 bool ChromeActiveDocument::LaunchUrl(const std::wstring& url,
                                      bool is_new_navigation) {
+  DCHECK(automation_client_.get() != NULL);
+
   url_.Allocate(url.c_str());
 
   if (!is_new_navigation) {
     WStringTokenizer tokenizer(url, L"&");
     // Skip over kChromeAttachExternalTabPrefix
     tokenizer.GetNext();
 
     uint64 external_tab_cookie = 0;
     if (tokenizer.GetNext()) {
       wchar_t* end_ptr = 0;
@@ skipping 64 matching lines @@
   return S_OK;
 }
 
 
 HRESULT ChromeActiveDocument::SetPageFontSize(const GUID* cmd_group_guid,
                                               DWORD command_id,
                                               DWORD cmd_exec_opt,
                                               VARIANT* in_args,
                                               VARIANT* out_args) {
   if (!automation_client_.get()) {
-    NOTREACHED() << "Invalid automtion client";
+    NOTREACHED() << "Invalid automation client";
     return E_FAIL;
   }
 
   switch (command_id) {
     case IDM_BASELINEFONT1:
       automation_client_->SetPageFontSize(SMALLEST_FONT);
       break;
 
     case IDM_BASELINEFONT2:
       automation_client_->SetPageFontSize(SMALL_FONT);
@@ skipping 161 matching lines @@
   ScopedComPtr<ITridentService2> trident_services;
   trident_services.QueryFrom(shell_browser);
   if (trident_services) {
     trident_services->FirePrivacyImpactedStateChange(wparam);
   } else {
     NOTREACHED() << "Failed to retrieve IWebBrowser2 interface.";
   }
   return 0;
 }