Windows: Make file_util::Delete("c:\\foo_dir", false) work correctly. Add more unit tests for Delete

chrome/installer/util/shell_util_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include <fstream>
 #include <iostream>
@@ skipping 80 matching lines @@
     test_dir_ = test_dir_.AppendASCII("ShellUtilTest");
 
     // Create a fresh, empty copy of this test directory.
     file_util::Delete(test_dir_, true);
     file_util::CreateDirectoryW(test_dir_);
     ASSERT_TRUE(file_util::PathExists(test_dir_));
   }
 
   virtual void TearDown() {
     // Clean up test directory
-    ASSERT_TRUE(file_util::Delete(test_dir_, false));
+    ASSERT_TRUE(file_util::Delete(test_dir_, true));
     ASSERT_FALSE(file_util::PathExists(test_dir_));
   }
 
   // The path to temporary directory used to contain the test operations.
   FilePath test_dir_;
 };
 };
 
 // Test that we can open archives successfully.
 TEST_F(ShellUtilTest, UpdateChromeShortcutTest) {
@@ skipping 38 matching lines @@
   // Now change only description to update shortcut and make sure icon index
   // doesn't change.
   const std::wstring description2(L"dummy description 2");
   EXPECT_TRUE(ShellUtil::UpdateChromeShortcut(exe_path.value(),
                                               shortcut_path.value(),
                                               description2, false));
   EXPECT_TRUE(VerifyChromeShortcut(exe_path.value(),
                                    shortcut_path.value(),
                                    description2, 1));
 }