Windows: Make file_util::Delete("c:\\foo_dir", false) work correctly. Add more unit tests for Delete

chrome/installer/util/create_dir_work_item_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 
 #include "base/base_paths.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
 #include "chrome/installer/util/work_item.h"
 #include "chrome/installer/util/create_dir_work_item.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
   class CreateDirWorkItemTest : public testing::Test {
    protected:
     virtual void SetUp() {
       // Name a subdirectory of the temp directory.
       ASSERT_TRUE(PathService::Get(base::DIR_TEMP, &test_dir_));
       test_dir_ = test_dir_.AppendASCII("CreateDirWorkItemTest");
 
       // Create a fresh, empty copy of this directory.
       file_util::Delete(test_dir_, true);
       file_util::CreateDirectoryW(test_dir_);
     }
     virtual void TearDown() {
       // Clean up test directory
-      ASSERT_TRUE(file_util::Delete(test_dir_, false));
+      ASSERT_TRUE(file_util::Delete(test_dir_, true));
       ASSERT_FALSE(file_util::PathExists(test_dir_));
     }
 
     // the path to temporary directory used to contain the test operations
     FilePath test_dir_;
   };
 };
 
 TEST_F(CreateDirWorkItemTest, CreatePath) {
   FilePath parent_dir(test_dir_);
@@ skipping 94 matching lines @@
 
   RemoveDirectory(dir_to_create_3.value().c_str());
   ASSERT_FALSE(file_util::PathExists(dir_to_create_3));
 
   work_item->Rollback();
 
   // dir_to_create_3 has already been deleted, Rollback should delete
   // the rest.
   EXPECT_FALSE(file_util::PathExists(dir_to_create_1));
 }