Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 17621: Pre-upstreaming scrubbing platform/graphics/chromium. (Closed)

Created:
11 years, 11 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
macdome, eseidel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Pre-upstreaming scrubbing platform/graphics/chromium. R=eseidel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7900

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -66 lines) Patch
M third_party/WebKit/WebCore/platform/graphics/chromium/FontCustomPlatformData.h View 1 2 chunks +28 lines, -26 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/FontCustomPlatformData.cpp View 1 4 chunks +31 lines, -25 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/FontLinux.cpp View 1 2 chunks +32 lines, -6 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/FontPlatformData.h View 1 2 chunks +30 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dglazkov
11 years, 11 months ago (2009-01-12 21:41:18 UTC) #1
dglazkov
Hold off on that... Looking at what's going on there.
11 years, 11 months ago (2009-01-12 21:45:52 UTC) #2
macdome_gmail.com
I was told to hold off. :) http://codereview.chromium.org/17621/diff/1/2 File third_party/WebKit/WebCore/platform/graphics/chromium/FontCustomPlatformData.cpp (right): http://codereview.chromium.org/17621/diff/1/2#newcode3 Line 3: * ...
11 years, 11 months ago (2009-01-12 21:49:32 UTC) #3
dglazkov
Sorry for the delay. I had to reorder includes in Mac project for this to ...
11 years, 11 months ago (2009-01-12 22:15:22 UTC) #4
macdome_gmail.com
11 years, 11 months ago (2009-01-12 22:18:41 UTC) #5
Looks fine.  Post to WebKit and I can make it official there too.

Powered by Google App Engine
This is Rietveld 408576698