Issue 1762012: Mac: Remove ToolbarButtonCell (and associated files).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1762012: Mac: Remove ToolbarButtonCell (and associated files). (Closed)

Created:
10 years, 8 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Mac: Remove ToolbarButtonCell (and associated files). .xib changes: change all ToolbarButtonCells to GradientButtonCells. (Previously committed at r45698, reverted at r45703. I don't know why the local build and the try succeeded. This time, I fixed the slightly-broken include.) BUG=42582 TEST=builds properly *and* toolbar buttons and find bar buttons still work as before Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45714

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+753 lines, -125 lines)			Patch
M	chrome/app/nibs/FindBar.xib	View	7 chunks	+23 lines, -29 lines	0 comments	Download
M	chrome/app/nibs/Toolbar.xib	View	20 chunks	+729 lines, -51 lines	0 comments	Download
M	chrome/browser/cocoa/extensions/browser_action_button.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/cocoa/toolbar_button_cell.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	chrome/browser/cocoa/toolbar_button_cell.mm	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	chrome/browser/cocoa/toolbar_button_cell_unittest.mm	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages