Issue 1762008: Fix copy paste: IsUint32() checks if value is unsigned, not signed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1762008: Fix copy paste: IsUint32() checks if value is unsigned, not signed. (Closed)

Created:
10 years, 8 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
ayembee

CC:
v8-dev

Visibility:
Public.

Description

Fix copy paste: IsUint32() checks if value is unsigned, not signed. Committed: http://code.google.com/p/v8/source/detail?r=4513

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ayembee

10 years, 8 months ago (2010-04-27 07:14:18 UTC) #2

On 2010/04/26 17:00:53, antonm wrote:
> Alexander,
> 
> may you have a look?

That's the one; looks good (I just happened to notice it on an auto-complete
tooltip and it threw me off track for a few seconds while I went to verify it
really was doing what I expected)

Expand Messages | Collapse Messages