Some additions to facilitate inclusion in BIOS.

Some additions to facilitate inclusion in BIOS.

1. Copy of generated file structures.h (in structures.h.snapshot).
2. Ifdef'ed code that shows how the TPM would be called through the EFI driver.

[Luigi Semenzato, 2010-04-23 01:08:27]

Hi Gaurav, please let me know if this would do.

[gauravsh, 2010-04-23 01:16:23]

lgtm

http://codereview.chromium.org/1761006/diff/2001/3002
File src/platform/tpm_lite/src/tlcl/tlcl.c (right):

http://codereview.chromium.org/1761006/diff/2001/3002#newcode152
src/platform/tpm_lite/src/tlcl/tlcl.c:152: status =
tgc_pass_through_to_tpm(tcg_protocol,
tcg_pass_thorugh

http://codereview.chromium.org/1761006/diff/2001/3002#newcode163
src/platform/tpm_lite/src/tlcl/tlcl.c:163: #endif
just to make clear #if this closes - add a comment /* USE_TPM_EMULATOR */

http://codereview.chromium.org/1761006/diff/2001/3002#newcode177
src/platform/tpm_lite/src/tlcl/tlcl.c:177: #endif
ditto

[Luigi Semenzato, 2010-04-23 15:55:59]

Thank you Gaurav, I made those changes.

http://codereview.chromium.org/1761006/diff/2001/3002
File src/platform/tpm_lite/src/tlcl/tlcl.c (right):

http://codereview.chromium.org/1761006/diff/2001/3002#newcode163
src/platform/tpm_lite/src/tlcl/tlcl.c:163: #endif
On 2010/04/23 01:16:23, gauravsh wrote:
> just to make clear #if this closes - add a comment /* USE_TPM_EMULATOR */

At some point I was compiling with some nitpicking old-C flags that didn't allow
such comments.  I had to give up using those, but I didn't go back and fix all
the #ifdefs.

[Luigi Semenzato, 2010-04-26 21:19:19]

Any more comments on this?

On 2010/04/23 15:55:59, Luigi Semenzato wrote:
> Thank you Gaurav, I made those changes.
> 
> http://codereview.chromium.org/1761006/diff/2001/3002
> File src/platform/tpm_lite/src/tlcl/tlcl.c (right):
> 
> http://codereview.chromium.org/1761006/diff/2001/3002#newcode163
> src/platform/tpm_lite/src/tlcl/tlcl.c:163: #endif
> On 2010/04/23 01:16:23, gauravsh wrote:
> > just to make clear #if this closes - add a comment /* USE_TPM_EMULATOR */
> 
> At some point I was compiling with some nitpicking old-C flags that didn't
allow
> such comments.  I had to give up using those, but I didn't go back and fix all
> the #ifdefs.

[gauravsh, 2010-04-26 21:41:21]

This looks good. LGTM.