Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 176046: Update hunspell DEPS to 1.2.8 (Closed)

Created:
11 years, 3 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
brettw, Hironori Bono
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update hunspell DEPS to 1.2.8 BUG=14756 TEST=Ran valgrind and unit_tests for SpellCheckTest and all passed successfully. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24998

Patch Set 1 #

Patch Set 2 : Update to newer DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellcheck_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mohamed Mansour
11 years, 3 months ago (2009-08-31 22:47:11 UTC) #1
brettw
LGTM
11 years, 3 months ago (2009-08-31 23:07:29 UTC) #2
Hironori Bono
11 years, 3 months ago (2009-09-01 00:41:35 UTC) #3
LGTM.
Thank you so much for your hard work that upgrades hunspell to 1.2.8. :)

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698