C++ Readability

core/cross/command_buffer/render_surface_cb.cc

 /*
  * Copyright 2009, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 32 matching lines @@
 RenderSurfaceCB::RenderSurfaceCB(ServiceLocator *service_locator,
                                  int width,
                                  int height,
                                  int mip_level,
                                  int side,
                                  Texture *texture,
                                  RendererCB *renderer)
     : RenderSurface(service_locator, width, height, texture),
       resource_id_(command_buffer::kInvalidResource),
       renderer_(renderer) {
+  DCHECK_GT(width, 0);
+  DCHECK_GT(height, 0);
+  DCHECK_GT(mip_level, -1);
   DCHECK(texture);
+  DCHECK(renderer);
 
   ResourceID id = renderer_->render_surface_ids().AllocateID();
   resource_id_ = id;
   CommandBufferHelper *helper = renderer_->helper();
   CommandBufferEntry args[4];
   args[0].value_uint32 = id;
   args[1].value_uint32 =
-      create_render_surface_cmd::Width::MakeValue(width) |
-      create_render_surface_cmd::Height::MakeValue(height);
+    create_render_surface_cmd::Width::MakeValue(width) |
+    create_render_surface_cmd::Height::MakeValue(height);
   args[2].value_uint32 =
     create_render_surface_cmd::Levels::MakeValue(mip_level) |
     create_render_surface_cmd::Side::MakeValue(side);
   args[3].value_uint32 =
-      reinterpret_cast<ResourceID>(texture->GetTextureHandle());
+    reinterpret_cast<ResourceID>(texture->GetTextureHandle());
   helper->AddCommand(command_buffer::CREATE_RENDER_SURFACE, 4, args);
 }
 
 RenderSurfaceCB::~RenderSurfaceCB() {
   Destroy();
 }
 
 void RenderSurfaceCB::Destroy() {
-  // This should never get called during rendering.
+  // This should never be called during rendering.
   if (resource_id_ != command_buffer::kInvalidResource) {
     CommandBufferHelper *helper = renderer_->helper();
     CommandBufferEntry args[1];
     args[0].value_uint32 = resource_id_;
     helper->AddCommand(command_buffer::DESTROY_RENDER_SURFACE, 1, args);
     renderer_->render_surface_ids().FreeID(resource_id_);
     resource_id_ = command_buffer::kInvalidResource;
   }
 }
 
 RenderDepthStencilSurfaceCB::RenderDepthStencilSurfaceCB(
     ServiceLocator *service_locator,
     int width,
     int height,
     RendererCB *renderer)
     : RenderDepthStencilSurface(service_locator, width, height),
       resource_id_(command_buffer::kInvalidResource),
       renderer_(renderer) {
+  DCHECK_GT(width, 0);
+  DCHECK_GT(height, 0);
+  DCHECK(renderer);
   ResourceID id = renderer_->depth_surface_ids().AllocateID();
   resource_id_ = id;
   CommandBufferHelper *helper = renderer_->helper();
   CommandBufferEntry args[2];
   args[0].value_uint32 = id;
   args[1].value_uint32 =
-      create_render_surface_cmd::Width::MakeValue(width) |
-      create_render_surface_cmd::Height::MakeValue(height);
+    create_render_surface_cmd::Width::MakeValue(width) |
+    create_render_surface_cmd::Height::MakeValue(height);
   helper->AddCommand(command_buffer::CREATE_DEPTH_SURFACE, 2, args);
 }
 
 void RenderDepthStencilSurfaceCB::Destroy() {
   if (resource_id_ != command_buffer::kInvalidResource) {
     CommandBufferHelper *helper = renderer_->helper();
     CommandBufferEntry args[1];
     args[0].value_uint32 = resource_id_;
     helper->AddCommand(command_buffer::DESTROY_DEPTH_SURFACE, 1, args);
     renderer_->depth_surface_ids().FreeID(resource_id_);
     resource_id_ = command_buffer::kInvalidResource;
   }
 }
 
 }  // namespace o3d