Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 176022: [Mac] Handle shift-delete when omnibox popup is up. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[Mac] Handle shift-delete when omnibox popup is up. When the user hits shift-delete (that's forward delete), attempt to delete the item highlighted from the list. This only seems to work for history items. http://crbug.com/20281 TEST=No idea. I've managed to delete an item, but most items seem immune to deletion, this code is calling the right place, but the match itself checks !deletable. Sometimes I have luck going to a site, then typing part of the URL and using shift-del on it.

Patch Set 1 #

Patch Set 2 : Bind to shift-deleteForward. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
11 years, 3 months ago (2009-08-28 19:46:32 UTC) #1
Scott Hess - ex-Googler
A little bird has informed me that this one is shift-delete on Windows, which means ...
11 years, 3 months ago (2009-08-28 20:28:31 UTC) #2
Scott Hess - ex-Googler
On 2009/08/28 20:28:31, shess wrote: > A little bird has informed me that this one ...
11 years, 3 months ago (2009-08-28 20:38:39 UTC) #3
rohitrao (ping after 24h)
11 years, 3 months ago (2009-08-28 21:59:14 UTC) #4
LGTM

My laptop doesn't have a delete key =(

Powered by Google App Engine
This is Rietveld 408576698