Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 17602: Updates to Visual Studio project generation to accomodate... (Closed)

Created:
11 years, 11 months ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Updates to Visual Studio project generation to accomodate recent changes and get rid of cut-and-paste: * Add generation of the new net_resource.vcproj file. * Accomodate the net\net.vsprops file. * New base.vcproj dependency in activex_shim_dll.vcproj. * New tld_cleanup.vcproj dependency in net.vcproj. * New ondemand_updates.vcproj dependencies in gcapi_{dll,lib}.vcproj. * Re-order dump_cache.vcproj dependencies to match new checked-in solutions. * New input file directory layout in zlib (minizip folder) and testing\gtest (hierarchy). * Use a new dest= argument to ChromeMSVSSolution() and ChromeMSVSProject() to get rid of cut-and-pste installation code, and provide a central point for controlling when/whether we want to generate the files only under the build directory, or drop them in place for checking in. * Comment out an unnecessarily verbose warning if the buildtarget is executed with an action that we don't map to specific Visual Studio settings. Sometimes this is normal and okay, but the warning should get restored at some point when we work out the precise conditions under which it makes sense. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7856

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -156 lines) Patch
M base/base_lib.scons View 2 chunks +3 lines, -6 lines 0 comments Download
M base/base_sln.scons View 2 chunks +1 line, -6 lines 0 comments Download
M base/base_unittests.scons View 2 chunks +1 line, -6 lines 0 comments Download
M base/debug_message.scons View 2 chunks +1 line, -6 lines 0 comments Download
M base/gfx/base_gfx.scons View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/browser.scons View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_sln.scons View 4 chunks +9 lines, -6 lines 0 comments Download
M net/crash_cache.scons View 2 chunks +1 line, -6 lines 0 comments Download
M net/dump_cache.scons View 2 chunks +2 lines, -7 lines 0 comments Download
M net/net_lib.scons View 4 chunks +5 lines, -17 lines 0 comments Download
M net/net_perftests.scons View 2 chunks +1 line, -6 lines 0 comments Download
M net/net_resources.scons View 1 chunk +22 lines, -0 lines 0 comments Download
M net/net_sln.scons View 2 chunks +2 lines, -6 lines 0 comments Download
M net/net_unittests.scons View 2 chunks +1 line, -6 lines 0 comments Download
M net/stress_cache.scons View 2 chunks +1 line, -6 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.scons View 2 chunks +1 line, -6 lines 0 comments Download
M sandbox/sandbox_sln.scons View 2 chunks +1 line, -6 lines 0 comments Download
M site_scons/site_tools/_Node_MSVS.py View 2 chunks +9 lines, -1 line 0 comments Download
M site_scons/site_tools/chromium_builders.py View 2 chunks +26 lines, -2 lines 0 comments Download
M skia/SConscript View 3 chunks +2 lines, -7 lines 2 comments Download
M testing/SConscript.gtest View 2 chunks +32 lines, -19 lines 0 comments Download
M third_party/libpng/libpng.scons View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/sqlite/SConscript View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/zlib/zlib.scons View 4 chunks +15 lines, -13 lines 0 comments Download
M webkit/activex_shim_dll/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/webkit_sln.scons View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sgk
TBR: tony,darin,nsylvain
11 years, 11 months ago (2009-01-10 22:22:20 UTC) #1
tony
LGTM http://codereview.chromium.org/17602/diff/1/13 File skia/SConscript (right): http://codereview.chromium.org/17602/diff/1/13#newcode306 Line 306: #'sgl/SkUnPreMultiply.cpp', Nit: Why is this commented out? ...
11 years, 11 months ago (2009-01-12 18:01:33 UTC) #2
sgk
http://codereview.chromium.org/17602/diff/1/13 File skia/SConscript (right): http://codereview.chromium.org/17602/diff/1/13#newcode306 Line 306: #'sgl/SkUnPreMultiply.cpp', On 2009/01/12 18:01:35, tony wrote: > Nit: ...
11 years, 11 months ago (2009-01-12 18:38:44 UTC) #3
Nicolas Sylvain
lg
11 years, 11 months ago (2009-01-12 18:43:14 UTC) #4
darin (slow to review)
11 years, 11 months ago (2009-01-12 18:56:29 UTC) #5
OK

Powered by Google App Engine
This is Rietveld 408576698