Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1759018: Update expectations for recent performance. (Closed)

Created:
10 years, 7 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Update expectations for recent performance. Adjust Mac 10.6 intl1 expectations. Improvement maybe from WebKit roll and changes upstream around r45865. xp-dual/moz/total_byte_* regressed in r45424. BUG=42841, 42882 TEST=xp-dual/moz/total_byte_* is green, Mac10.6 intl1 page cycler is green TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf_expectations/perf_expectations.json View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
chase
10 years, 7 months ago (2010-04-29 22:33:49 UTC) #1
Nicolas Sylvain
10 years, 7 months ago (2010-04-30 00:40:01 UTC) #2
lg

On Thu, Apr 29, 2010 at 3:33 PM, <chase@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Update expectations for recent performance.
>
> Adjust Mac 10.6 intl1 expectations.  Improvement maybe
> from WebKit roll and changes upstream around r45865.
> xp-dual/moz/total_byte_* regressed in r45424.
>
> BUG=42841,42882
> TEST=xp-dual/moz/total_byte_* is green, Mac10.6 intl1
> page cycler is green
> TBR=nsylvain@chromium.org
>
> Please review this at http://codereview.chromium.org/1759018/show
>
> Affected files:
>  M tools/perf_expectations/perf_expectations.json
>
>
> Index: tools/perf_expectations/perf_expectations.json
> diff --git a/tools/perf_expectations/perf_expectations.json
> b/tools/perf_expectations/perf_expectations.json
> index
>
fc071deb0f8566674b84420d9986b7a29c7eedcb..3cb0c7f29b7a5e6ee5e210470897a7c990ad1fc1
> 100644
> --- a/tools/perf_expectations/perf_expectations.json
> +++ b/tools/perf_expectations/perf_expectations.json
> @@ -17,7 +17,7 @@
>  "mac-release-10.5/moz/times/t": {"delta": 80, "var": 80},
>  "mac-release-10.5/startup/warm/t": {"delta": 0, "var": 20},
>  "mac-release-10.6/dhtml/times/t": {"delta": -12, "var": 14},
> - "mac-release-10.6/intl1/times/t": {"delta": 350, "var": 100},
> + "mac-release-10.6/intl1/times/t": {"delta": 260, "var": 100},
>  "mac-release-10.6/intl2/times/t": {"delta": 400, "var": 60},
>  "mac-release-10.6/morejs/times/t": {"delta": -40, "var": 50},
>  "mac-release-10.6/moz/times/t": {"delta": 35, "var": 50},
> @@ -40,8 +40,8 @@
>  "xp-release-dual-core/intl2/times/t": {"delta": 0, "var": 30},
>  "xp-release-dual-core/morejs/times/t": {"delta": 0, "var": 20},
>  "xp-release-dual-core/moz/times/t": {"delta": 0, "var": 20},
> - "xp-release-dual-core/moz/total_byte_b/IO_b": {"delta": -270, "var": 90},
> - "xp-release-dual-core/moz/total_byte_r/IO_r": {"delta": -285, "var": 90},
> + "xp-release-dual-core/moz/total_byte_b/IO_b": {"delta": -120, "var": 90},
> + "xp-release-dual-core/moz/total_byte_r/IO_r": {"delta": -130, "var": 90},
>  "xp-release-dual-core/moz/total_op_b/IO_op_b": {"delta": -1100, "var":
> 740},
>  "xp-release-dual-core/moz/total_op_r/IO_op_r": {"delta": -600, "var":
> 730},
>  "xp-release-dual-core/moz/vm_peak_b/vm_pk_b": {"delta": 700000, "var":
> 800000},
>
>
>

Powered by Google App Engine
This is Rietveld 408576698